Skip to content

Prevent accidental publishing to npm #4098

@nikwen

Description

@nikwen

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Forge version

7.10.2

Electron version

39.2.7

Operating system

All

Last known working Forge version

No response

Expected behavior

Mistyping your publish command should never publish your source code to npm.

Actual behavior

npm run publish is very similar to npm publish, which publishes all your source code to npm.

See https://www.instagram.com/reel/DSQKadiAlrk/ where a user ran into this.

Steps to reproduce

Don't. :)

But npm publish should do the trick.

Additional information

Ideas for how to solve this:

  • Add "private": true to package.json for our project templates
  • Change publish script name to something else, e.g., release

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions