Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

@xinghuayu007 xinghuayu007 commented Nov 19, 2025

What changes are proposed in this pull request?

How was this patch tested?

Related issue: #11027

@xinghuayu007 xinghuayu007 changed the title Add clang-tidy to check cpp code [GLUTEN-11027]Add clang-tidy to check cpp code Nov 19, 2025
@xinghuayu007 xinghuayu007 force-pushed the my/clang_tidy branch 3 times, most recently from ccac8e8 to 2d5f9ff Compare November 19, 2025 06:28
@PHILO-HE PHILO-HE changed the title [GLUTEN-11027]Add clang-tidy to check cpp code [GLUTEN-11027] Add clang-tidy to check cpp code Nov 19, 2025
@xinghuayu007 xinghuayu007 force-pushed the my/clang_tidy branch 22 times, most recently from fde7a6a to 84e345b Compare November 24, 2025 06:49
@PHILO-HE
Copy link
Member

@xinghuayu007 xinghuayu007 force-pushed the my/clang_tidy branch 21 times, most recently from bd5b5ba to 4af9de6 Compare December 1, 2025 06:46
@zhouyuan
Copy link
Contributor

@xinghuayu007 @PHILO-HE based on the issue description, the target here is to check the CPP code format? We already have a format checker with clang-format here, is there a gap in this existing tool?
https://github.com/apache/incubator-gluten/blob/main/.github/workflows/code_format.yml

@xinghuayu007
Copy link
Contributor Author

@xinghuayu007 @PHILO-HE based on the issue description, the target here is to check the CPP code format? We already have a format checker with clang-format here, is there a gap in this existing tool? https://github.com/apache/incubator-gluten/blob/main/.github/workflows/code_format.yml

@zhouyuan , there are different. 'clang-format' focuses solely on code appearance and layout, like automatically adjusts indentation, line breaks, spacing, brace positioning, alignment, etc. 'clang-tidy' focuses on code quality, logic, and potential errors, like checks for potential bugs, suggests using more modern C++ features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants