Skip to content

Conversation

@sadpandajoe
Copy link
Member

…or DatasetList

Add complete test coverage for the DatasetList page including:

  • Component tests: DatasetList main, behaviors, ListView, permissions, DuplicateDatasetModal
  • Integration tests: multi-component orchestration and hook-level state management
  • Test helpers: shared fixtures and utilities

Tests breakdown:

  • DatasetList.test.tsx: 28 component tests
  • DatasetList.behavior.test.tsx: 10 behavior tests
  • DatasetList.listview.test.tsx: 36 ListView tests
  • DatasetList.permissions.test.tsx: 14 permission tests
  • DuplicateDatasetModal.test.tsx: 9 modal tests
  • DatasetList.integration.test.tsx: 2 integration tests

Total: 99 tests (97 component + 2 integration)

Includes fixes for:

  • antd 5.27.6 compatibility (semantic selectors)
  • Async cleanup patterns for reliable test execution
  • Test timing and synchronization issues

🤖 Generated with Claude Code

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…or DatasetList

Add complete test coverage for the DatasetList page including:
- Component tests: DatasetList main, behaviors, ListView, permissions, DuplicateDatasetModal
- Integration tests: multi-component orchestration and hook-level state management
- Test helpers: shared fixtures and utilities

Tests breakdown:
- DatasetList.test.tsx: 28 component tests
- DatasetList.behavior.test.tsx: 10 behavior tests
- DatasetList.listview.test.tsx: 36 ListView tests
- DatasetList.permissions.test.tsx: 14 permission tests
- DuplicateDatasetModal.test.tsx: 9 modal tests
- DatasetList.integration.test.tsx: 2 integration tests

Total: 99 tests (97 component + 2 integration)

Includes fixes for:
- antd 5.27.6 compatibility (semantic selectors)
- Async cleanup patterns for reliable test execution
- Test timing and synchronization issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Remove explicit cleanup() calls (RTL handles this automatically)
- Add jest.setTimeout(30000) to match ChartList test pattern
- Standardize fetchMock cleanup using resetHistory() + restore()
- Fix eslint warnings by adding explicit assertions to 3 tests
- Remove unused cleanup imports

These changes improve test stability when running in parallel and
align with patterns used in other test files (e.g., ChartList).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant