Skip to content

Conversation

@EliasB-NU
Copy link

Like I mentioned in #917 , I would love to have the docker image for arm64 as well.
I made a few changes, since I don't understand any of this matrix variables I just copy pasted my config and adjusted it. You would need to add the checks you have and the matrix vars you use.

@fliiiix fliiiix force-pushed the patch-1 branch 3 times, most recently from b6d46bb to 55c9b89 Compare April 7, 2025 08:57
@fliiiix
Copy link
Member

fliiiix commented Apr 7, 2025

doesn't work 🤷

ERROR: invalid tag "ghcr.io/docat-org/docat:$(git describe --tags)": invalid reference format

@EliasB-NU
Copy link
Author

I will look into it later today

@EliasB-NU
Copy link
Author

I am a little bit confused, the tags in the docker image correspond to the tags of the releases, but the actions only run on pushes and pull requests.
Where did the previous actions get the tags from?

@fliiiix
Copy link
Member

fliiiix commented Apr 9, 2025

I am a little bit confused, the tags in the docker image correspond to the tags of the releases, but the actions only run on pushes and pull requests. Where did the previous actions get the tags from?

I guess previously

      - name: Build Image
        run: |
          docker build . --build-arg DOCAT_VERSION=$(git describe --tags --always) --tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }}
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:unstable

      - name: tag latest and version on release
        run: |
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:$(git describe --tags)
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:latest
        if: startsWith(github.event.ref, 'refs/tags')

the part using $(git describe --tags) only was executed for startsWith(github.event.ref, 'refs/tags') tag builds
Basically i guess always build and tag 'unstable' and only on tag builds also tag 'latest' and the actual tag

@fliiiix
Copy link
Member

fliiiix commented Apr 9, 2025

This might work but it seems this environment is not able to install yarn packages???

#22 211.6 error Error: https://registry.yarnpkg.com/@mui/icons-material/-/icons-material-6.1.3.tgz: ESOCKETTIMEDOUT

@EliasB-NU
Copy link
Author

I see, it should work, because I could compile it on my arm server, maybe its some weird issue with github workers.

@fliiiix
Copy link
Member

fliiiix commented Apr 10, 2025

Maybe just updating the dependencies will fix it lets see 🤷 #919

@fliiiix
Copy link
Member

fliiiix commented Apr 10, 2025

ok idk seems not to work for our docker image / build process 🤷

@EliasB-NU
Copy link
Author

I don't understand it, maybe someone else in the future will have the same problem and fix it xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants