Add toggle button for secret visibility in InteractionsInputDialog #13584
+65
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added JavaScript function to toggle input type between text and password - Added FluentButton with eye icons next to SecretText inputs - Implemented state management for visibility tracking - Added CSS styling for the toggle button layout - Used existing GridValueMaskShowValue/HideValue resource strings Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add toggle button for viewing secret text inputs
Add toggle button for password visibility in InteractionsInputDialog
Dec 16, 2025
JamesNK
reviewed
Dec 16, 2025
src/Aspire.Dashboard/Components/Dialogs/InteractionsInputDialog.razor.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Dashboard/Components/Dialogs/InteractionsInputDialog.razor.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Dashboard/Components/Dialogs/InteractionsInputDialog.razor.cs
Outdated
Show resolved
Hide resolved
…RenderAsync, use SafeDisposeAsync - Removed _secretTextVisibility dictionary, tracked on InputViewModel.IsSecretTextVisible property instead - Moved OnAfterRenderAsync back to original location after OnParametersSet - Used JSInteropHelpers.SafeDisposeAsync for proper JS module disposal - Simplified IsSecretTextVisible method by directly accessing property - Made GetSecretTextIcon static as it doesn't access instance data Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13584Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13584" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds password visibility toggle functionality to secret text inputs in the InteractionsInputDialog, allowing users to reveal or hide password values using eye/eye-off icons.
Key changes:
- Added toggle button with eye icons to SecretText inputs for showing/hiding password text
- Implemented JavaScript interop to toggle input type between "password" and "text"
- Added
IsSecretTextVisibleproperty toInputViewModelto track visibility state per input field
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
InputViewModel.cs |
Added IsSecretTextVisible property to track visibility state |
InteractionsInputDialog.razor.js |
Added JavaScript function to toggle password input type |
InteractionsInputDialog.razor.css |
Updated CSS for flex container layout and spacing |
InteractionsInputDialog.razor.cs |
Added JS interop setup, toggle handler, and icon getter method |
InteractionsInputDialog.razor |
Added toggle button UI next to SecretText inputs |
InteractionInputField.razor |
Renamed CSS class and adjusted progress ring styling |
JamesNK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a toggle button to SecretText inputs in
InteractionsInputDialogthat allows users to reveal/hide password text. The button displays to the right of the input field using eye icons consistent with the dashboard's existing masking UI.Update: Moved toggle button inside text box area. This UX pattern is more popular
Implementation:
typeattribute between "password" and "text"InputViewModel.IsSecretTextVisibleproperty to support multiple password fields in same dialogGridValueMaskShowValue/HideValueresource strings andIcons.Regular.Size16.Eye/EyeOfficonsJSInteropHelpers.SafeDisposeAsyncfor proper JS module disposal with circuit disconnect handlingFiles changed:
InteractionsInputDialog.razor- Added toggle button UI to SecretText caseInteractionsInputDialog.razor.cs- State management and JS interopInteractionsInputDialog.razor.js- Toggle functionInteractionsInputDialog.razor.css- Flex layout stylingInputViewModel.cs- AddedIsSecretTextVisibleproperty for tracking visibility stateChecklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.