[do not merge] ci test pr #12951
Draft
[do not merge] ci test pr #12951
+205
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created TaskHostNodeKey record struct combining HandshakeOptions and NodeId - Updated NodeProviderOutOfProcTaskHost to use TaskHostNodeKey as dictionary keys - Added reverse mapping from communication nodeId to TaskHostNodeKey for packet routing - Updated TaskHostTask to use TaskHostNodeKey instead of bit-packed int - Removed 256-node limitation for multithreaded builds - Added unit tests for TaskHostNodeKey Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
…of hash Address code review feedback: Use Interlocked.Increment for generating unique communication node IDs instead of GetHashCode() to avoid potential hash collisions. Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Address code review feedback: Use int keys directly for packet routing dictionaries (_nodeIdToPacketFactory and _nodeIdToPacketHandler) instead of going through an intermediate TaskHostNodeKey lookup. The TaskHostNodeKey is now only used where we need to identify nodes by their logical identity (HandshakeOptions + scheduledNodeId) for node existence checks. Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Reverts the simplification made in the previous commit per reviewer request. The intermediate dictionary provides cleaner lookup from communication node IDs to TaskHostNodeKey for packet routing. Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Apply reviewer feedback for O(1) packet routing performance: - Use int keys (_nodeIdToPacketFactory, _nodeIdToPacketHandler) for packet routing - Keep _nodeContexts keyed by TaskHostNodeKey for acquisition logic - Remove intermediate _nodeIdToNodeKey dictionary - Use _activeNodes with int (nodeId) instead of TaskHostNodeKey This gives type-safe Keys for managing node lifecycle while maintaining direct Integer lookups for high-frequency packet routing. Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
- Add VerifyThrow in DisconnectFromHost to verify context exists - Restore assert in CreateNode to verify no duplicate context - Eliminate linear search in NodeContextTerminated by adding _nodeIdToNodeKey reverse mapping - Consolidate to single NodeContextTerminated(int nodeId) method - Keep SendData(int, INodePacket) throwing NotImplementedException (required by interface but not used for task hosts) Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
…rocTaskHost.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes