Mainlining of Fast Snap logic #804
Draft
+4,947
−2,214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Nov 24, 2025
Collaborator
magik6k
left a comment
magik6k
left a comment
There was a problem hiding this comment.
Some comments to my code, some comments around the merge. Overall looks really good, let's keep this moving
Collaborator
There was a problem hiding this comment.
iiuc those changes were re-implemented in a slightly different way in main, so we don't really want to backport anything ipni-related.
* build * 2 * 3 * build gotchas * right shape * requirements include cuda * get build fixed * cuda for everyone * add golang for ci * stop deleting my stuff * try with gcc flag * auto-nvme-setup opt-out * ci build fix attempt * fix outdated base image * gofmt, flag- no avx512bf16 * try cuda setup * do like working job * try without cuda * try cude in install-deps * cuda info in github env * make spdk happy * deps * gcc12 * ubuntu-latest is not 2404 but 2004 * ci: missing deps, fix ubuntus * supra: rm mbx wrapper, fix poseidon constants wait, native default arch * review fixes --------- Co-authored-by: Łukasz Magiera <magik6k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, this is only a merge, but I need it reviewed as a number of things were changed by both sides. I generally went with the "everyone's right" approach, but where functions were restructured by both sides, this may be incorrect.
DO NOT SUBMIT: Only safe for Magik to test
Once approved, it still needs other changes to avoid breaking anyone. This PR will be a start for those changes.