Skip to content

Conversation

@smowton
Copy link
Contributor

@smowton smowton commented Dec 16, 2025

Expected failure; requires concurrent internal PR.

@smowton smowton requested a review from a team as a code owner December 16, 2025 11:44
Copilot AI review requested due to automatic review settings December 16, 2025 11:44
@github-actions github-actions bot added the Java label Dec 16, 2025
@smowton smowton force-pushed the smowton/admin/java-buildless-paths-test branch from 1c05889 to b91f9ac Compare December 16, 2025 11:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new integration test to verify that the paths and paths-ignore configuration options work correctly with Java buildless mode. The test ensures that only files from specified paths are included in the analysis while explicitly excluded paths are ignored.

  • Adds a test configuration that includes files from include/ directory while excluding files from include/exclude/ subdirectory
  • Creates test data files in both included and excluded paths to validate filtering behavior
  • Verifies that only files matching the path criteria are analyzed and appear in query results

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
java/ql/integration-tests/java/buildless-paths/test.ql Query file that tests for Java source files and XML files to validate path filtering
java/ql/integration-tests/java/buildless-paths/test.py Test script that creates a database with buildless mode and applies the codescanning config
java/ql/integration-tests/java/buildless-paths/test.expected Expected output showing only files from include/ directory (excluding the exclude/ subdirectory)
java/ql/integration-tests/java/buildless-paths/codescanning-config.yml Configuration file defining path inclusion and exclusion patterns
java/ql/integration-tests/java/buildless-paths/sibling/ShouldNotAppear1.xml Test data file outside included paths that should be filtered out
java/ql/integration-tests/java/buildless-paths/sibling/ShouldNotAppear1.java Test data file outside included paths that should be filtered out
java/ql/integration-tests/java/buildless-paths/include/exclude/ShouldNotAppear3.xml Test data file in explicitly excluded path that should be filtered out
java/ql/integration-tests/java/buildless-paths/include/exclude/ShouldNotAppear3.java Test data file in explicitly excluded path that should be filtered out
java/ql/integration-tests/java/buildless-paths/include/ShouldAppear2.xml Test data file that should appear in results based on path filters
java/ql/integration-tests/java/buildless-paths/include/ShouldAppear2.java Test data file that should appear in results based on path filters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +2
import os
import os.path
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports for os and os.path are not used in this test file and should be removed.

Suggested change
import os
import os.path

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant