PHP: Add extractor and initial queries #21062
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmvarela
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an initial PHP extractor and query support to the CodeQL repository. The implementation includes a Rust-based tree-sitter extractor, database schema generation, basic security queries, and minimal taint tracking capabilities. The author notes this is a minimal viable product (MVP) submission, with another more complete implementation by @drmckay also in progress.
Key changes:
- Tree-sitter-based PHP extractor written in Rust
- Auto-generated database schema and TreeSitter.qll library
- Three initial security queries: DangerousBuiltinCall, TaintedDangerousBuiltinCall, and AssertWithStringArgument
- Basic taint analysis and security modeling for PHP superglobals
Reviewed changes
Copilot reviewed 54 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| php/tools/.sh, php/tools/.cmd | Shell and batch scripts for test execution and file indexing |
| php/scripts/create-extractor-pack.sh | Build script for creating the extractor pack |
| php/ql/test/query-tests/Security/* | Test cases and expected results for security queries |
| php/ql/src/Security/*.ql | Three security queries for dangerous builtins and assert misuse |
| php/ql/lib/codeql/php/security/*.qll | Basic security modeling (sources, sinks, taint) |
| php/ql/lib/codeql/php/ast/*.qll | Call abstraction library and TreeSitter wrapper |
| php/extractor/src/*.rs | Rust extractor implementation (main, generator, extractor, autobuilder) |
| php/extractor/Cargo.toml | Rust dependencies configuration |
| php/**/BUILD.bazel | Bazel build configuration files |
| .github/workflows/php.yml | CI workflow for PHP extractor and tests |
| misc/bazel/3rdparty/* | Third-party dependency configuration for tree-sitter-php |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vmvarela
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #12376
Just as I'm opening the pull request, I see that @drmckay has just opened another one for the same thing, and much more complete!
(I'm just adding it in case my work is of any use to him)