Support Django 5.2 and 6.0 #277
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 130 130
Branches 14 14
=========================================
Hits 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| run: | | ||
| pip install -r requirements.txt | ||
| pip install "Django~=${{ matrix.django-version }}.0" . | ||
| pip install "django~=${{ matrix.django-version }}.0a1" . |
There was a problem hiding this comment.
This tests with alpha versions of Django and later, as noted last time:
https://github.com/jazzband/dj-database-url/pull/260/files#r1957380313
This time round, I would like to advocate that you merge as-is. dj-database-url is stable and doesn't depend on many Django internals, but announcing Django 6.0 support will help users upgrade early. Any issues that do appear after the alpha phase can always be fixed. I'm testing all my Django-related packages on the alpha!
There was a problem hiding this comment.
I repeat my words from over there "I don't think we should be doing this yet, as we can't guarantee just because we support a 5.2 6.0 alpha that we'll definitely work with the released version"
If it's that fast to fix, we can do it immediately after the release but I think it's a very bad idea to declare support for something not actually released yet.
There was a problem hiding this comment.
Agreed, adding support for something not yet released is not ideal in my mind. Once a django 6 release is baked we will support the relevant pinning.
3 participants
Rehash of #260 with the next Django version added in.
I'm not sure why #260 was closed rather than merged, I never received a response.