Checked for not empty instead of not null because sometimes it returns empty array.

[ankurvr]

Not getting Store pickup enabled on checkout and not getting list of stores to pickup after entering zipcode/pincode in input box while checkout

Description (*)

Due to invalid condition check and no condition check, wrong condition is being added in searchcriteria stores list was not getting results.

Fixed Issues (if relevant)

1. Not getting storepickup option on checkout because of wrong condition getting added in searchcriteria object. #3079: Not getting storepickup option on checkout because of wrong condition getting added in searchcriteria object.

Manual testing scenarios (*)

1. Create 1 or more new sources with Use as Pickup Location option enabled in it.
2. Create new stock for default website using newly created sources
3. Assign products to newly created sources and add inventory in it so it can be available for pickup.
4. Enable In store Delivery shipping method from Store Config/Sales/Delivery Methods.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[sidolov]

@magento run all tests

[sidolov]

@magento run all tests

[sidolov]

@magento run all tests

[engcom-Delta]

Hi @ankurvr during testing PR was found an issue: exception error is appear when product is assigned to two sources
Manual testing scenario:

• Create two new sources with Use as Pickup Location option enabled in it.
  
  

• Create new stock for default website using newly created sources

• Assign products to newly created sources
  

• Enable In-Store Delivery shipping method

• Add product to cart and go to checkout

• Click on Pick In Store Tab

• Click Select Store button under Store section

• Enter zip code in Select Store pop-up window

Result:
❌ Exception error appear
Report ID: webapi-5f186daf9d056; Message: Notice: Undefined index: austin in /var/www/html/magento2pr/ext/magento/inventory/InventoryInStorePickup/Model/SearchResult/Strategy/DistanceBased.php on line 78 {"exception":"[object] (Exception(code: 0): Report ID: webapi-5f186daf9d056; Message: Notice: Undefined index: austin in /var/www/html/magento2pr/ext/magento/inventory/InventoryInStorePickup/Model/SearchResult/Strategy/DistanceBased.php on line 78 at /var/www/html/magento2pr/lib/internal/Magento/Framework/Webapi/ErrorProcessor.php:207, Exception(code: 0): Notice: Undefined index: austin in /var/www/html/magento2pr/ext/magento/inventory/InventoryInStorePickup/Model/SearchResult/Strategy/DistanceBased.php on line 78 at /var/www/html/magento2pr/lib/internal/Magento/Framework/App/ErrorHandler.php:61)"} []

Could you take a look?

[ankurvr]

@engcom-Delta Sure will check and get back to you.

[ankurvr]

@engcom-Delta Can you please confirm these preconditions for using Multi sources and Pickup In-store?

1. Stores -> Configuration -> Catalog -> Inventory

2. Stores -> Configuration -> Sales -> Delivery Methods -> "In-store Delivery" -> (Search Radius) field have value

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests, WebAPI Tests

[engcom-Hotel]

Hello @ankurvr,

Thank you for your contribution!

We have reviewed this PR and it seems some functional tests are failing due to this change.

Also we have tried to run some existing functional tests without PR branch it we can see the "In Store pickup" option for e.g.:

• StorefrontLoggedInCustomerPickupInStorePreselectedTest
• GuestCustomerPlaceOrderWithPickupInStoreMethodWithGoogleAPIEnabledTest

Please look into it.

[engcom-Hotel]

Hello @ankurvr,

Have you got a chance to look into this review comment #3080 (review)

Thank you