-
Notifications
You must be signed in to change notification settings - Fork 9k
Clean up SCREEN_INFORMATION even further #19648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
| til::rect _rcAltSavedClientOld{}; | ||
| bool _fAltWindowChanged{ false }; | ||
|
|
||
| SCREEN_INFORMATION* _psiAlternateBuffer = nullptr; // The VT "Alternate" screen buffer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, there's nothing wrong with type name{ value } syntax :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's many arguments that can be made against {}. For instance, anything that compiles with = means that initialization is implicit. Assuming no one wrote a non-trivial non-explicit object constructor, this further implies that seeing = means that it's definitely trivial (not just implicit), and that {} is potentially non-trivial and should raise an eye-brow).
That of course excludes things such as default constructors that are non-trivial such as cppwinrt's which allocate an object to avoid "null"s (BAH! I mean it's nice, but BAH!).
|
but also, why |
|
I mean the |

A continuation of #19645. Maintainer modifications were disabled, unfortunately.