fix(server): correctly decode public file paths with reserved URI characters #21254
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racters The dev server previously used decodeURI() when resolving public assets. decodeURI() does not decode reserved characters like %23 (#) or %3F (?), causing valid public files such as my#image.svg to return 404 in dev. Replacing it with decodeURIComponent() correctly decodes these filenames and fixes the resolution of percent-encoded asset paths. Fixes vitejs#20799.
Member
|
Please add tests to confirm the fix. |
Author
|
I have added the test for percent-encoded public file paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev server previously used
decodeURI()when resolvingpublicassets.decodeURI()does not decode reserved characters like%23 (#) or %3F (?), causing valid public files such asmy#image.svgto return404 in dev.Replacing it with
decodeURIComponent()correctly decodes these filenames and fixes the resolution of percent-encoded asset paths.Fixes #20799.