-
Notifications
You must be signed in to change notification settings - Fork 19
Prefer UTF-8 for DID Parameters #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
|
I think it is important to not remove the % encoding language, and possible the UTF-8 language is also misleading. Given that we are still following RFC3986, which says when a character that is not part of the unreserved ASCII set is to be included in a URI, its UTF-8 byte sequence is first determined. Then, each byte in that sequence is percent-encoded. So, technically, a UTF-8 string would break current parsing. It may be that this wholesale change is the wrong layer for whatever we're aiming for here. |
|
This was discussed during the #did meeting on 04 December 2025. View the transcriptw3c/did-resolution#217<ottomorac> Prefer UTF-8 for DID Parameters #217 ottomorac: related to an issue raised by Addison Philips as part of the i18n review <ottomorac> Also appreciate reviews on 219, 248, 253 |
|
This was discussed during the #did meeting on 04 December 2025. View the transcriptw3c/did-resolution#217JoeAndrieu: I just added a comment. The language that removed the percent-encoding bit that caught my eye. pchampin: is percent-encoding our responsibility? JoeAndrieu: as we are defining URL parameter, they are defined as being part of a URL, so they need to be percent-encoded manu: there are 3 different things here <ottomorac1> Addison talked about RFC3987: w3c/did-resolution#200 (comment) manu: another point is: are we talking about the the value space, which need to support UTF-8, or the lexical space, where percent-encoding is required <Zakim> TallTed, you wanted to check whether we're staying with RFC 3986/7 or moving to WHAT WG's URL spec TallTed: RCF3986 and RFC3987 travel together, they don't really make sense without each other <ottomorac1> w3c/did-resolution#200 (comment) TallTed: (mostly the same, but slightly different) <Zakim> JoeAndrieu, you wanted to say I see the fix JoeAndrieu: my concerns have actually been addressed manu: now reading Addison's commentary, it is aligned with what I said. ottomorac: Will pointed out that DID parameters were dropped from DID core 1.1 . manu: if that right? JoeAndrieu: if that's right, it feels weird to me. manu: DID URLs define parameters, it talks mostly about the lexical space JoeAndrieu: looking at the differences between RFC3986 and RFC3987. They are not many, but they may be significant. manu: going back to the PR. I think it is fine as is. JoeAndrieu: it addresses my concern with percent-encoding. manu: trying to get closure on this. §3.1 in RFC3987 describes how to map an IRI to a URI. JoeAndrieu: I was looking to the ABNF, §2.2. 'ucschar' is a class of new characters manu: ucschar is not UTF-8, but can be converted to UTF-8. JoeAndrieu: +1 |
|
Reviewing the minutes, this looks good to merge. |
|
While not part of this PR (which I'm fine to merge), Line 324 -- immediately above the first change -- is incorrect, as the |
This PR addresses #200 and #201 :
versionTimewhich should probably remain as ASCII only in my view)Preview | Diff