Define generic datetime format for DID resolution and use throughout spec #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip-abramson
requested review from
ChristopherA,
danpape,
dmitrizagidulin,
mccown and
peacekeeper
as code owners
wip-abramson
added
the
discuss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, I just want to check it is along the right lines.
So far I have added a Datetime section to the spec with a definition of the datetime format that references the VCDM and uses the adjust to UTC language.
I then updated versionTime to reference this section as the format for the datetime.
A review of the Datetime definition would be appreciated. I was unsure about keeping the ASCII string part in, but I didn't see anything about that in the VCDM representing time section - https://w3c.github.io/vc-data-model/#representing-time.
/?
Also, is the way I am referencing the Datetime section from versionTime okay with the normative language?
Once I have had some reviews and we settle on some language, I will apply the change to all datetime properties throughout the spec.
Preview | Diff