Keep compatibility for subclasses overriding __finalize__ for concat/merge #63394
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Dec 17, 2025
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Did you discover this in geopandas?
Member
Author
|
Yes, and we have a fix for it as well (to be released before the final 3.0 release), but it seems easy to also provide compat for those who would test the latest pandas with one earlier release of geopandas (instead of giving some cryptic error) |
Member
|
Thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up on #60357, keeping the existing names for the objects that subclasses might check for in custom logic in
__finalize__.We can deprecate accessing those additional names later, but that is not critical for 3.0