Skip to content

Keep compatibility for subclasses overriding __finalize__ for concat/merge #63394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 1 commit into from
Dec 17, 2025
+9 −4
Merged

Keep compatibility for subclasses overriding __finalize__ for concat/merge #63394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pandas/core/reshape/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def _get_result(
result = sample._constructor_from_mgr(mgr, axes=mgr.axes)
result._name = name
return result.__finalize__(
types.SimpleNamespace(input_objs=objs), method="concat"
types.SimpleNamespace(input_objs=objs, objs=objs), method="concat"
)

# combine as columns in a frame
Expand All @@ -620,7 +620,7 @@ def _get_result(
df = cons(data, index=index, copy=False)
df.columns = columns
return df.__finalize__(
types.SimpleNamespace(input_objs=objs), method="concat"
types.SimpleNamespace(input_objs=objs, objs=objs), method="concat"
)

# combine block managers
Expand Down Expand Up @@ -660,7 +660,9 @@ def _get_result(
)

out = sample._constructor_from_mgr(new_data, axes=new_data.axes)
return out.__finalize__(types.SimpleNamespace(input_objs=objs), method="concat")
return out.__finalize__(
types.SimpleNamespace(input_objs=objs, objs=objs), method="concat"
)


def new_axes(
Expand Down
5 changes: 4 additions & 1 deletion pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,10 @@ def get_result(self) -> DataFrame:
self._maybe_restore_index_levels(result)

return result.__finalize__(
types.SimpleNamespace(input_objs=[self.left, self.right]), method="merge"
types.SimpleNamespace(
input_objs=[self.left, self.right], left=self.left, right=self.right
),
method="merge",
)

@final
Expand Down
Loading